helm: move verbose and sign args outside artifactory check #121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
--verbose
and--sign
arguments were only applied when artifactory was disabled.Changes:
--verbose
and--sign
argument blocks outside of theartifactory.enabled
if-else statementBefore: Arguments were only added when
persistence.artifactory.enabled
wasfalse
After: Arguments are added based on
verboseLogging
andextensionSigning
values regardless of artifactory configurationResolves the issue described in lines 75-80 of
helm/templates/deployment.yaml
.