Skip to content

Conversation

blink-so[bot]
Copy link
Contributor

@blink-so blink-so bot commented Sep 19, 2025

This PR fixes an issue where the --verbose and --sign arguments were only applied when artifactory was disabled.

Changes:

  • Moved --verbose and --sign argument blocks outside of the artifactory.enabled if-else statement
  • These arguments now apply regardless of artifactory configuration

Before: Arguments were only added when persistence.artifactory.enabled was false
After: Arguments are added based on verboseLogging and extensionSigning values regardless of artifactory configuration

Resolves the issue described in lines 75-80 of helm/templates/deployment.yaml.

Move --verbose and --sign arguments outside of the artifactory.enabled
if-else block so they are applied regardless of artifactory configuration.

Previously, these arguments were only applied when artifactory was disabled.

Co-authored-by: bjornrobertsson <[email protected]>
Copy link


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

Copy link
Contributor Author

blink-so bot commented Sep 19, 2025

The CLA Assistant check is failing because the bot account needs to sign the CLA. This is expected for automated contributions. A human maintainer can bypass this check when reviewing the PR, or the bot account can be added to the CLA allowlist if desired.

The actual code changes have passed the helm linting checks successfully. ✅

@code-asher code-asher marked this pull request as ready for review September 19, 2025 18:50
@code-asher code-asher merged commit 2e4fd81 into main Sep 19, 2025
1 of 2 checks passed
@code-asher code-asher deleted the blink/move-verbose-sign-args-outside-artifactory-check branch September 19, 2025 18:50
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant