Add unit tests for social login flows

[shai-almog]

Summary

• add focused GoogleConnect tests to verify token validation paths and persisted tokens
• cover FacebookConnect logout, native bridging, and error handling behaviour with new tests
• extend the test implementation helper so unit tests can configure and inspect mocked connections
• ensure social connect tests execute through @formtest so the Codename One runtime is initialized before assertions

Testing

• mvn -f maven/core-unittests/pom.xml test (fails: missing com.codenameone:codenameone-factory dependency)

---

https://chatgpt.com/codex/tasks/task_e_69050dae650083318037f7d427d63162

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 875 total, 0 failed, 0 skipped
• 📊 Line coverage: 19.41% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.services.RSSService$1 – 0.00%
    • com.codename1.io.services.ImageDownloadService – 0.00%
    • com.codename1.io.services.ImageDownloadService$6 – 0.00%
    • com.codename1.io.services.ImageDownloadService$1 – 0.00%
    • com.codename1.io.services.ImageDownloadService$3 – 0.00%
    • com.codename1.io.services.ImageDownloadService$2 – 0.00%
    • com.codename1.io.services.ImageDownloadService$5 – 0.00%
    • com.codename1.io.services.ImageDownloadService$4 – 0.00%
    • com.codename1.io.services.TwitterRESTService$1 – 0.00%
    • com.codename1.io.services.RSSService$1FinishParsing – 0.00%

Static Analysis

• ❌ SpotBugs: 993 findings (High: 92, Normal: 484, Low: 417) [HTML preview] [Download]
  • Top findings
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:38 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:30 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/util/ColorUtil.java:33 – Field isn't final but should be (rule: MS_SHOULD_BE_FINAL)
    • High: CodenameOne/src/com/codename1/charts/views/XYChart.java:128 – Call to equals() comparing different types (rule: EC_UNRELATED_TYPES)
    • High: CodenameOne/src/com/codename1/compat/java/util/Objects.java:51 – Redundant nullcheck of value known to be non-null (rule: RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE)
    • …and 988 more
• ❌ PMD: 2726 findings (P2: 1, P3: 649, P4: 2076) [HTML preview] [Download]
  • Top findings
    • P2: CodenameOne/src/com/codename1/ui/Display.java:1012 – Avoid using a branching statement as the last in a loop. (rule: AvoidBranchingStatementAsLastInLoop)
    • P3: CodenameOne/src/com/codename1/facebook/FacebookRESTService.java:76 – Avoid unused constructor parameters such as 'token'. (rule: UnusedFormalParameter)
    • P3: CodenameOne/src/com/codename1/impl/CodenameOneImplementation.java:8380 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/impl/FullScreenAdService.java:103 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • P3: CodenameOne/src/com/codename1/io/CSVParser.java:134 – These nested if statements could be combined (rule: CollapsibleIfStatements)
    • …and 2721 more
• ❌ Checkstyle: 192601 findings (Warning: 192601) [HTML preview] [Download]
  • Top findings
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:30:1 – Extra separation in import group before 'java.io.IOException' (rule: CustomImportOrderCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:32 – First sentence of Javadoc is missing an ending period. (rule: SummaryJavadocCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:36 – Line is longer than 100 characters (found 143). (rule: LineLengthCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:39:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • Warning: CodenameOne/src/com/codename1/db/ThreadSafeDatabase.java:40:5 – 'member def modifier' has incorrect indentation level 4, expected level should be 2. (rule: IndentationCheck)
    • …and 192596 more

Generated automatically by the PR CI workflow.