Fix symbolic links not properly encoded in ZIP archives #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To encode the symbolic links `AbstractZipArchiver` uses `ZipEncoding` but it does not use it properly. It uses the whole backing array of the returned ByteBuffer while it it should use it only up to the buffer limit. This may lead to additional characters at the end of the symbolic link. This does not manifest as a bug because Common Compress up to 1.14 returns a ByteBuffer that wraps a byte array containing the encoded payload. But Common Compress 1.15 returns new implementation and we need to fix it before upgrading. Actually that is how it was found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To encode the symbolic links
AbstractZipArchiverusesZipEncodingbut it does not use it properly.It uses the whole backing array of the returned ByteBuffer
while it it should use it only up to the buffer limit.
This may lead to additional characters at the end of the
symbolic link.
This does not manifest as a bug because Common Compress up to 1.14
returns a ByteBuffer that wraps a byte array containing the
encoded payload. But Common Compress 1.15 returns new
implementation and we need to fix it before upgrading.
Actually that is how it was found.