Skip to content

⚡️ Speed up function _setup_sentry_tracing by 93% #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⚡️ Speed up function _setup_sentry_tracing by 93% #51

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions sentry_sdk/integrations/spark/spark_driver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
from sentry_sdk._types import Event, Hint
from pyspark import SparkContext

_spark_context_class = None


class SparkIntegration(Integration):
identifier = "spark"
Expand Down Expand Up @@ -100,23 +102,39 @@ def _activate_integration(sc):

def _patch_spark_context_init():
# type: () -> None
from pyspark import SparkContext
global _spark_context_class
if _spark_context_class is None:
from pyspark import SparkContext

_spark_context_class = SparkContext
else:
SparkContext = _spark_context_class

spark_context_init = SparkContext._do_init

if getattr(spark_context_init, "_sentry_patched", False):
return

@ensure_integration_enabled(SparkIntegration, spark_context_init)
def _sentry_patched_spark_context_init(self, *args, **kwargs):
# type: (SparkContext, *Any, **Any) -> Optional[Any]
rv = spark_context_init(self, *args, **kwargs)
_activate_integration(self)
return rv

_sentry_patched_spark_context_init._sentry_patched = True
SparkContext._do_init = _sentry_patched_spark_context_init


def _setup_sentry_tracing():
# type: () -> None
from pyspark import SparkContext
global _spark_context_class
if _spark_context_class is None:
from pyspark import SparkContext

_spark_context_class = SparkContext
else:
SparkContext = _spark_context_class

if SparkContext._active_spark_context is not None:
_activate_integration(SparkContext._active_spark_context)
Expand Down