Skip to content

⚡️ Speed up function monte_carlo_pi by 15% #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

⚡️ Speed up function monte_carlo_pi by 15% #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions src/numpy_pandas/np_opts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,11 @@ def slow_matrix_inverse(matrix: List[List[float]]) -> List[List[float]]:

def monte_carlo_pi(num_samples: int) -> float:
"""Estimate π using Monte Carlo method."""
inside_circle = 0

for _ in range(num_samples):
x = random.uniform(-1, 1)
y = random.uniform(-1, 1)

if x**2 + y**2 <= 1:
inside_circle += 1

# Batch sample coordinates to list or tuple for reduced lookup overhead
coords = (
(random.uniform(-1, 1), random.uniform(-1, 1)) for _ in range(num_samples)
)
inside_circle = sum(x * x + y * y <= 1 for x, y in coords)
return 4 * inside_circle / num_samples


Expand Down