Skip to content

Conversation

MaCleodWalker
Copy link

Changes:
Updated Firebase peer dependency to version 10.0.0 from 9.0.0 to align with the latest stable release.
Verified compatibility with the existing codebase and other dependencies.

@Dev1994
Copy link

Dev1994 commented Oct 8, 2023

Would be awesome if we could get this PR through. My github workflow currently fails due to this when npm i --omit dev --no-audit executes from the FirebaseExtended/action-hosting-deploy@v0 step.

@bran-dy-b
Copy link

@Dev1994 Until this is merged, I've been avoiding errors by adding the --legacy-peer-deps option to npm install commands. If the Firebase GitHub Action is running some npm install command that is failing, you can configure your project with a .npmrc with that option enabled.

Note that this is generally not recommended, as you will have to manually make sure your project is installing compatible peer dependencies. My project is simple enough that it's not an issue for now. Hope this helps!

@TobyNorhave
Copy link

Agreed on this part! - Please update the dependencies for firebase. I love your SvelteFire 🔥

@eyeofastarte
Copy link

+1 Through when using legacy dependencies, my Cloudflare build was failing. @brandonbaraban mentioned the fix, I also found it here: https://stackoverflow.com/a/73433707

# .npmrc
legacy-peer-deps=true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants