Add code comments to QR code generation #517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shane32
commented
May 4, 2024
Shane32
changed the title
Shane32
changed the title
codebude
reviewed
May 5, 2024
codebude
approved these changes
May 5, 2024
|
Do you plan more updates/commits? Otherwise I would be fine, merging it now. |
|
No, I'd merge it now. |
|
Actually, there's one last method I'd comment.... hold on. |
codebude
approved these changes
May 5, 2024
|
I finished btw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves readability, given that the code to generate a QR code is very complex, consisting of nearly 1,700 lines of raw code.
Requires PR #516 to be merged first for proper GitHub comparison.
Although most of the commented methods are private, it would be beneficial to verify the comments for accuracy. They seem fine to me.