Update ArtQRCode.cs #408
Merged
Update ArtQRCode.cs #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed dot size calculaction
|
Previously the pixel size factor does not appear to have any effect. With pixel size factor of 0.7: (default is 0.8) Before:
After:
Demo of default size factor of 0.8:
It would seem that this PR should be merged, assuming this is the intent of the pixel size factor. However, any user code will now generate with smaller dots than previously, as previously it acted as though pixelSizeFactor was 1, and the default is 0.8. Test hashes will need to be updated. Perhaps the default should be set to 1.0 going forward, to match the previous version's default behavior (??) |
Changed the default to 1.0 to avoid breaking changes due to bugfix in pixelSizeFactor calculation
Shane32
reviewed
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed dot size calculation where the size is divided instead of multiplied.