Skip to content

Bugfix/291 iconborderwidth doesnt work #351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 23, 2021
Merged

Bugfix/291 iconborderwidth doesnt work #351

merged 2 commits into from
Nov 23, 2021

Conversation

codebude
Copy link
Owner

@codebude codebude commented Nov 23, 2021 •
edited
Loading

Summary
This PR fixes/implements the following bugs:

  • The icon's border wasn't rendered (due to a former code removal, which made the parameter useless)
  • The previous method for border rendering was refactored, to work without Region.Exclude(path) (which earlier led to problems on Linux environments)
  • More testcases were written and existing ones improved

Test plan
image

Closing issues
Fixes #291

@codebude codebude merged commit f10daa1 into master Nov 23, 2021
@codebude codebude deleted the bugfix/291-iconborderwidth-doesnt-work branch November 23, 2021 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

iconBorderWidth Doesn't work
1 participant
@codebude