Setup landing page #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Authform component as a container to handle presentational logic for SignUpForm and LoginForm. Add PropTypes module and proptypes to components.
angelocordon
added
enhancement
lpatmo
approved these changes
Feb 18, 2020
| }; | ||
|
|
||
| return ( | ||
| <Box component={Paper} elevetion={3} padding={3}> |
There was a problem hiding this comment.
Is elevetion meant to be elevation?
|
|
||
| return ( | ||
| <Box component={Paper} elevetion={3} padding={3}> | ||
| {activeSignUpForm && <SignUpForm toggleActiveForm={toggleActiveForm} />} |
There was a problem hiding this comment.
Interesting approach -- I'm used to writing {activeSignUpForm ? <SignUpForm toggleActiveForm={toggleActiveForm} /> : <LoginForm>}
, but this is fine :)
sebbel
approved these changes
Feb 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Update Landing Page UI with registration/authentication form and copy.
Related Tickets & Documents
Closes #3
Before & After
Before
After
