Update to Rails 7.2 #2343
Update to Rails 7.2 #2343
Conversation
olleolleolle
force-pushed
the
rails72
branch
2 times, most recently
from
b591b4c to
468399b
Compare
|
Are you planning to squash this PR when merging, to remove the non-passing commits from the git history? |
Rails 7.2 app:update Rails 7.2: enum with positional args Rails 7.2: enum positional args Rails 7.2: Enable 7.2 defaults
|
@mroderick Now it is 1 commit. |
|
|
||
| # Disable serving static files from `public/`, relying on NGINX/Apache to do so instead. | ||
| config.public_file_server.enabled = ENV['RAILS_SERVE_STATIC_FILES'].present? | ||
| # config.public_file_server.enabled = false |
There was a problem hiding this comment.
The default is true. EDIT: https://guides.rubyonrails.org/configuring.html#config-public-file-server-enabled
The ENV is set on Heroku.
The result; the same.
| # See the ActiveSupport::ParameterFilter documentation for supported notations and behaviors. | ||
| Rails.application.config.filter_parameters += [ | ||
| :passw, :secret, :token, :_key, :crypt, :salt, :certificate, :otp, :ssn | ||
| :passw, :email, :secret, :token, :_key, :crypt, :salt, :certificate, :otp, :ssn |
| @@ -1,51 +1,42 @@ | |||
| # Puma can serve each request in a thread from an internal thread pool. | |||
There was a problem hiding this comment.
Is all of this rails defaults now?
| environment ENV.fetch("RAILS_ENV") { "development" } | ||
|
|
||
| # Specifies the `pidfile` that Puma will use. | ||
| pidfile ENV.fetch("PIDFILE") { "tmp/pids/server.pid" } |
|
|
||
| production: | ||
| adapter: redis | ||
| url: <%= ENV.fetch("REDIS_URL") { "redis://localhost:6379/1" } %> |
There was a problem hiding this comment.
We don't have Heroku Cache currently.
There was a problem hiding this comment.
Right perhaps we also don't use Action Cable (websocket).
There was a problem hiding this comment.
Mostly because it is automatically generated each time the upgrade dance is performed. Benefit: By having it, unused, there's less diff to manage when upgrading.
There was a problem hiding this comment.
IMHO it should at least contain a comment that it's currently not used.
3 participants
This PR upgrades the configuration to Rails 7.2 configuration.
I attempted to keep close to what Rails outputs, so that the update to the next version of Rails is not so difficult.
In order to deploy this: