Skip to content

Conversation

@stefanb
Copy link
Contributor

@stefanb stefanb commented Jun 25, 2025

The Go 1.25 incompatibility found in
* Homebrew/homebrew-core#226636

then:
* reported upstream in cockroachdb/swiss#48
* fixed upstream cockroachdb/swiss#49
@stefanb stefanb requested a review from a team as a code owner June 25, 2025 00:05
@stefanb stefanb requested a review from jbowens June 25, 2025 00:05
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde RaduBerinde merged commit 69a5809 into cockroachdb:pebble-release-2.0 Jun 25, 2025
22 checks passed
@RaduBerinde
Copy link
Member

Thanks!

@stefanb stefanb deleted the pebble-release-2.0-go-1.25 branch June 25, 2025 04:19
@stefanb
Copy link
Contributor Author

stefanb commented Jun 25, 2025

Thanks, @RaduBerinde!

I suggest to create a release (2.0.6?) so that downstream users have plenty of time to include this before Go 1.25 is released (scheduled for August).

This is currently the only unreleased change on the pebble-release-2.0 branch: v2.0.5...pebble-release-2.0

@RaduBerinde
Copy link
Member

Done: https://github.com/cockroachdb/pebble/releases/tag/v2.0.6

@stefanb
Copy link
Contributor Author

stefanb commented Jun 25, 2025

Thanks! 🚀

gammazero added a commit to ipfs/kubo that referenced this pull request Jul 2, 2025
… support (#10850)

* Upgrade github.com/cockroachdb/swiss for Go 1.25 support

Go 1.25 incompatibility detected in
* Homebrew/homebrew-core#226636

then:
* reported upstream in cockroachdb/swiss#48
* fixed upstream cockroachdb/swiss#49

This PR brings this fix upstream to kubo.

The fix was brought to github.com/cockroachdb/pebble/v2 in
* cockroachdb/pebble#4954

And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6
Which is now used.

Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6

* Upgrade to go-ds-pebble v0.5.1 for pebbel v2.0.6 support

---------

Co-authored-by: gammazero <[email protected]>
lidel pushed a commit to ipfs/kubo that referenced this pull request Jul 8, 2025
… support (#10850)

* Upgrade github.com/cockroachdb/swiss for Go 1.25 support

Go 1.25 incompatibility detected in
* Homebrew/homebrew-core#226636

then:
* reported upstream in cockroachdb/swiss#48
* fixed upstream cockroachdb/swiss#49

This PR brings this fix upstream to kubo.

The fix was brought to github.com/cockroachdb/pebble/v2 in
* cockroachdb/pebble#4954

And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6
Which is now used.

Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6

* Upgrade to go-ds-pebble v0.5.1 for pebbel v2.0.6 support

---------

Co-authored-by: gammazero <[email protected]>
(cherry picked from commit 6f0c1de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants