-
Notifications
You must be signed in to change notification settings - Fork 514
go.mod: update github.com/cockroachdb/swiss to support Go 1.25 #4954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
RaduBerinde
merged 1 commit into
cockroachdb:pebble-release-2.0
from
stefanb:pebble-release-2.0-go-1.25
Jun 25, 2025
Merged
go.mod: update github.com/cockroachdb/swiss to support Go 1.25 #4954
RaduBerinde
merged 1 commit into
cockroachdb:pebble-release-2.0
from
stefanb:pebble-release-2.0-go-1.25
Jun 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Go 1.25 incompatibility found in * Homebrew/homebrew-core#226636 then: * reported upstream in cockroachdb/swiss#48 * fixed upstream cockroachdb/swiss#49
Member
This was referenced Jun 25, 2025
RaduBerinde
approved these changes
Jun 25, 2025
Member
|
Thanks! |
Contributor
Author
|
Thanks, @RaduBerinde! I suggest to create a release (2.0.6?) so that downstream users have plenty of time to include this before Go 1.25 is released (scheduled for August). This is currently the only unreleased change on the |
Member
Contributor
Author
|
Thanks! 🚀 |
gammazero
added a commit
to ipfs/kubo
that referenced
this pull request
Jul 2, 2025
… support (#10850) * Upgrade github.com/cockroachdb/swiss for Go 1.25 support Go 1.25 incompatibility detected in * Homebrew/homebrew-core#226636 then: * reported upstream in cockroachdb/swiss#48 * fixed upstream cockroachdb/swiss#49 This PR brings this fix upstream to kubo. The fix was brought to github.com/cockroachdb/pebble/v2 in * cockroachdb/pebble#4954 And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6 Which is now used. Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6 * Upgrade to go-ds-pebble v0.5.1 for pebbel v2.0.6 support --------- Co-authored-by: gammazero <[email protected]>
lidel
pushed a commit
to ipfs/kubo
that referenced
this pull request
Jul 8, 2025
… support (#10850) * Upgrade github.com/cockroachdb/swiss for Go 1.25 support Go 1.25 incompatibility detected in * Homebrew/homebrew-core#226636 then: * reported upstream in cockroachdb/swiss#48 * fixed upstream cockroachdb/swiss#49 This PR brings this fix upstream to kubo. The fix was brought to github.com/cockroachdb/pebble/v2 in * cockroachdb/pebble#4954 And released in https://github.com/cockroachdb/pebble/releases/tag/v2.0.6 Which is now used. Full changelog: cockroachdb/pebble@v2.0.3...v2.0.6 * Upgrade to go-ds-pebble v0.5.1 for pebbel v2.0.6 support --------- Co-authored-by: gammazero <[email protected]> (cherry picked from commit 6f0c1de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Go 1.25 incompatibility found in
then: