opentelemetry: gitignore cockroachdb_metrics.go #156335
Open
+1
−2,638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently added a tool to automatically generate `cockroachdb_metrics.go` file which exports all metrics from CockroachDB for opentelemetry. This generated file was checked in, but I think it makes more sense to gitignore it (since it's automatically generated when necessary anyway) - this will reduce toil when adding new metrics as well as reduce the merge drift when backporting metrics too. Release note: None
yuzefovich
requested review from
shailendra-patel and
williamchoe3
and removed request for
a team
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
|
Concretely, this would make backporting changes like in #156334 easier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently added a tool to automatically generate
cockroachdb_metrics.gofile which exports all metrics from CockroachDB for opentelemetry. This generated file was checked in, but I think it makes more sense to gitignore it (since it's automatically generated when necessary anyway) - this will reduce toil when adding new metrics as well as reduce the merge drift when backporting metrics too.Epic: None
Release note: None