cmd/reduce: fix parsing of DO blocks #156131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
yuzefovich
approved these changes
Oct 25, 2025
There was a problem hiding this comment.
Thanks!
@yuzefovich reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @mw5h)
Parsing DO blocks requires that plpgsql be initialized, which reduce previously failed to do, causing it to SEGV upon encountering a DO block in the file being reduced. This change imports the plpgsql parser to hit its init() function, which resolves the issue. Epic: none Release note: None
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing DO blocks requires that plpgsql be initialized, which reduce previously failed to do, causing it to SEGV upon encountering a DO block in the file being reduced. This change imports the plpgsql parser to hit its init() function, which resolves the issue.
Epic: none
Release note: None