workload/schemachanger: exclude array types for ltree and citext #154991
+17
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we added version gates for ltree and citext, but this only included non-array types. This meant we could still incorrectly use arrays of these types in mixed version states. To address this, this patch detects the array variants of these types. Fixes: cockroachdb#154637 Release note: None
fqazi
requested review from
DarrylWong and
golgeek
and removed request for
a team
Member
|
This change is |
rafiss
approved these changes
Oct 7, 2025
Collaborator
Author
|
@rafiss TFTR bors r+ |
Contributor
|
Based on the specified backports for this PR, I applied new labels to the following linked issue(s). Please adjust the labels as needed to match the branches actually affected by the issue(s), including adding any known older branches. Issue #154637: branch-release-25.4. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we added version gates for ltree and citext, but this only included non-array types. This meant we could still incorrectly use arrays of these types in mixed version states. To address this, this patch detects the array variants of these types.
Fixes: #154637
Release note: None