*: improve some tests #110008
Merged
*: improve some tests #110008
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knz
requested review from
herkolategan,
michae2 and
srosenberg
and removed request for
a team
Member
|
This change is |
knz
force-pushed
the
20230905-fix-tenant-tests
branch
from
0908869 to
da39f62
Compare
knz
force-pushed
the
20230905-fix-tenant-tests
branch
from
da39f62 to
a958297
Compare
knz
force-pushed
the
20230905-fix-tenant-tests
branch
from
a958297 to
4a88e30
Compare
knz
requested review from
a team and
abarganier
and removed request for
a team
This was referenced Sep 5, 2023
stevendanna
reviewed
Sep 8, 2023
Collaborator
stevendanna
left a comment
stevendanna
left a comment
There was a problem hiding this comment.
I didn't add much on top of Yahor's review. But there is one required change in my opinion.
Huge thanks for continuing to drive this forward.
Release note: None
Release note: None
Release note: None
Release note: None
Release note: None
The dialer for a given SQL layer dials across SQL servers using instance IDs. Release note: None
Release note: None
Release note: None
and link it to follow-up issue cockroachdb#110014. Release note: None
Release note: None
Release note: None
Release note: None
This incomplete configuration was noticed by `TestStatusGetFiles` once enabled to run over secondary tenants. This extra test coverage is enabled in the subsequent commit. Release note: None
Release note: None
Release note: None
This way the optimizing call to `TestingRestart` on the cap watcher is performed in all tests that use this API. Release note: None
knz
force-pushed
the
20230905-fix-tenant-tests
branch
from
e73b28b to
e3461bc
Compare
yuzefovich
approved these changes
Sep 8, 2023
Member
yuzefovich
left a comment
yuzefovich
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r2, 13 of 13 files at r3, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @abarganier, @herkolategan, @michae2, @srosenberg, and @stevendanna)
abarganier
approved these changes
Sep 8, 2023
Contributor
abarganier
left a comment
abarganier
left a comment
There was a problem hiding this comment.
LGTM, I appreciate the clarity that's added from this overhaul.
| s := serverutils.StartServerOnly(t, base.TestServerArgs{}) | ||
| defer s.Stopper().Stop(ctx) | ||
| srv := serverutils.StartServerOnly(t, base.TestServerArgs{ | ||
| DefaultTestTenant: base.TestIsForStuffThatShouldWorkWithSecondaryTenantsButDoesntYet(110002), |
Contributor
There was a problem hiding this comment.
base.TestIsForStuffThatShouldWorkWithSecondaryTenantsButDoesntYet(110002)
☠️ 😂
| baseCfg.SpanConfigsDisabled = kvServerCfg.BaseConfig.SpanConfigsDisabled | ||
| baseCfg.EnableDemoLoginEndpoint = kvServerCfg.BaseConfig.EnableDemoLoginEndpoint | ||
| baseCfg.DefaultZoneConfig = kvServerCfg.BaseConfig.DefaultZoneConfig | ||
| baseCfg.HeapProfileDirName = kvServerCfg.BaseConfig.HeapProfileDirName |
Contributor
There was a problem hiding this comment.
nit: does this impact tests? Or is it just some cleanup along the way.
Contributor
Author
There was a problem hiding this comment.
This is exercised in tests; its lack was noticed by a failure in #110001.
Contributor
Author
|
TFYRs! bors r=stevendanna,yuzefovich,abargainier |
Contributor
|
Build succeeded: |
craig bot
pushed a commit
that referenced
this pull request
Sep 11, 2023
110001: serverutils: redirect the implicit `ApplicationLayerInterface` properly r=stevendanna a=knz All commits but the last 3 are from #110008. Epic: CRDB-18499 Prior to this patch, the *implicit* `ApplicationLayerInterface` implementation inside `TestServerInterface` was redirecting to `SystemLayer()`. This was confusing, likely the source of bugs, and resulted in insufficient test coverage. This commit fixes it. followup issues identified thanks to this work: - actual bug: #110003 - possible bug: #110002 - possible bug: #110007 - possible bug: #110012 - feature gap: #110009 - feature gap: #110018 - feature gap: #110019 - feature gap: #110020 - feature gap: #110022 - feature gap: #110023 - feature gap: #110024 Co-authored-by: Raphael 'kena' Poss <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the test improvements prerequisite to #110001.
Epic: CRDB-18499