Skip to content

first draft tooling update #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 8, 2024
Merged

first draft tooling update #964

merged 6 commits into from
May 8, 2024

Conversation

dsweber2
Copy link
Contributor

@dsweber2 dsweber2 commented Apr 29, 2024 •
edited by dshemetov
Loading

The tooling is woefully out of date. This is an attempt to fix that. It updates the drop-down menu, and the overview page.

I also added some css to render sub-menu's differently, since the list was rather long.

fix #864

@dsweber2 dsweber2 self-assigned this Apr 29, 2024
@netlify Netlify
Copy link

netlify bot commented Apr 29, 2024 •
edited
Loading

✅ Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit d4001c2
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/663407f09d538d00088b0ae2
😎 Deploy Preview https://deploy-preview-964--cmu-delphi-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

carlynvandyke
carlynvandyke reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@carlynvandyke carlynvandyke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏 👏 Thank you for doing this!

@dshemetov
Copy link
Collaborator

Thanks for diving in! Getting this visual bug, maybe we can avoid it by just calling that entry "Dashboards"?

image

@dsweber2
Copy link
Contributor Author

dsweber2 commented Apr 30, 2024 •
edited
Loading

If you mean the new floating over the edge, I think that's an element to highlight what's changed

But yeah, might as well just call it dashboards.

Oh, and to be clear, @brookslogan, @nmdefries, @dshemetov, if you end up making larger changes/suggestions, feel free to just push directly to this branch, it'd probably be easier/more convenient than PR/PR's.

dsweber2 and others added 3 commits April 30, 2024 10:45
@dsweber2
Shorter names frequently better
6a4db56
@dshemetov
refactor+fix: tools update
09834c2 
* packages and dashboards now link to tools overview
* consistent capitalization of epiprocess/epipredict
* aggregate all the tooling subpages into a single .md file for simplicity and to fix the header links
* remove unused shortcode
@dshemetov
refactor: update tooling page
083cc57 
* move covid forecasting below flu
* move eval dashboard up
* use consistent references to covid-19 in headers
* use consistent references to Delphi Epidata API
* remove duplicate verbiage
* improve epiprocess description
* improve epipredict description
dsweber2
dsweber2 commented May 1, 2024
View reviewed changes
@dsweber2
Copy link
Contributor Author

dsweber2 commented May 1, 2024

updated based on live feedback during meeting. Could probably use some help on wording and making forecasting wins a bit clearer

@dshemetov
refactor: tools and code updates
d4001c2 
* fix some broken header links
* consistent capitalization
* rename Packages to Code
* remove unused shortcodes
* change landing page Our API to Our Tools and
  link to tools page
* update the footer to contain a link to Code
@dshemetov
Copy link
Collaborator

Updated a few things:

  • renamed new Packages section to Code, did an editing pass on the language around that
  • removed a few unused shortcodes
  • changed the Our API link on the landing page to be Our Tools and linked to the Tools Overview instead of the very dense and outdated https://cmu-delphi.github.io/delphi-epidata/
  • updated the footer to contain a link to Code

@dsweber2 dsweber2 enabled auto-merge May 8, 2024 21:25
dshemetov
dshemetov approved these changes May 8, 2024
View reviewed changes
Copy link
Collaborator

@dshemetov dshemetov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty happy to merge these changes. The site is not perfect, but certainly a substantial improvement to the out of date information we have live right now.

@melange396 @carlynvandyke let us know what you think and we can make some final tweaks as needed and hopefully merge soon

@dsweber2 dsweber2 merged commit f466abe into dev May 8, 2024
@dsweber2 dsweber2 deleted the toolingDocs branch May 8, 2024 22:42
@nmdefries
Copy link
Contributor

Comments from Roni

The Delphi Epidata Dashboard in the pulldown menu is fine, but the Delphi Epidata Dashboard link within the "Dashboards" pulldown item gets a 404.

Also, in the Tools pulldown menu, "EpiVis" should be replaced with the more descriptive "Epi Signal Visualization".

@dshemetov
Copy link
Collaborator

@nmdefries Thanks! I'll make a fix in another branch.

@dshemetov dshemetov mentioned this pull request Jun 4, 2024
Merged
@melange396 melange396 mentioned this pull request Jun 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carlynvandyke carlynvandyke carlynvandyke left review comments

@dshemetov dshemetov dshemetov approved these changes

@brookslogan brookslogan Awaiting requested review from brookslogan

@nmdefries nmdefries Awaiting requested review from nmdefries nmdefries is a code owner

@rlunde rlunde Awaiting requested review from rlunde

@melange396 melange396 Awaiting requested review from melange396 melange396 is a code owner

Assignees

@dsweber2 dsweber2

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Listing Epidatr as a tool

4 participants

@dsweber2 @dshemetov @nmdefries @carlynvandyke