Skip to content

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented May 26, 2021

No description provided.

@netlify
Copy link

netlify bot commented May 26, 2021

✔️ Deploy Preview for cmu-delphi-main ready!

🔨 Explore the source changes: 8e93505

🔍 Inspect the deploy log: https://app.netlify.com/sites/cmu-delphi-main/deploys/6166223413aa0f0007fd79e3

😎 Browse the preview: https://deploy-preview-359--cmu-delphi-main.netlify.app

@sgratzl sgratzl changed the title V1 new menu experiment Change to New Menu Structure May 27, 2021
@sgratzl sgratzl requested a review from krivard May 27, 2021 18:48
@sgratzl sgratzl self-assigned this May 27, 2021
@sgratzl sgratzl marked this pull request as ready for review May 27, 2021 19:14
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first item in each menu links to the same place as the menu header. Can we just drop the first item, or is it recommended to include it?

eg proposing to get rid of "Delphi's Influenca Task Group" from the below, since "Flu" already goes there

image

@sgratzl
Copy link
Member Author

sgratzl commented Jun 7, 2021

The first item in each menu links to the same place as the menu header. Can we just drop the first item, or is it recommended to include it?

it is intended, since the top level menu item has two purposes like showing the sub menu but also linking to a page. As far as I remember we decided to duplicate the top menu link since it isn't obvious that you can also click on the top menu when the submenu is already popping up as a reaction to your mouse interaction.

@krivard
Copy link
Contributor

krivard commented Jun 7, 2021

I'm collecting comments through Slack and will transfer them into change requests here

@krivard
Copy link
Contributor

krivard commented Jun 7, 2021

hmmm, or i can just commit to your branch, up to you

@sgratzl
Copy link
Member Author

sgratzl commented Jun 7, 2021

hmmm, or i can just commit to your branch, up to you

might be more efficient since it just changing the config.toml file

@Raphael-Hyde
Copy link
Contributor

New nav LGTM - I agree that we should have the persistent nav label and 1st menu item link to the same page. Thanks guys.

@sgratzl sgratzl marked this pull request as draft June 17, 2021 13:54
@sgratzl
Copy link
Member Author

sgratzl commented Sep 27, 2021

Now just a question. In this new setup, how am I supposed to navigate between menu subsubitems, for example, things pages Explore an Indicator and Explore a Location within the COVIDcast Dashboard?

atm there is a back button at the top: on the list
image

but you should also be able to use your history back button.

@sgratzl
Copy link
Member Author

sgratzl commented Sep 27, 2021

re breadcrumbs:

the top level pages, e.g. /about didn't have breadcrumb so far, since it would just be an entry that is not clickable.

that is also the reason why Blog (/blog) doenst have a submenu, since for compatibility reason it keeps the old url (/blog) which is top level.

@ryantibs
Copy link
Member

ryantibs commented Sep 27, 2021

Wow thanks @sgratzl that was fast work! Two things remaining.

  1. Navigating between explore and indicator / explore a location / etc. within the COVIDcast dashboard. I don't think a back button at the top (or in the browser) is sufficient because it's not even clear to the user what subpages we have here. They'd only be able to get to these subpages by clicking around on the dashboard itself. Are there any other for ways we can display the substructure here to the user? EDIT: To be clear all I'm looking for is a way somewhere that's visible (top of the page?) to select between "Explore a Location" and "Explore an Indicator" ---- just those two.

  2. Breadcrumbs. I think of it this way: a user would land on Delphi and click the About menu and see a bunch of menu items. And if they clicked on About Delphi or Blog then I would think I'm navigating no differently then if I clicked on Our Team. (Even is the URL structure was different.) But as a user I see different things happen with the subheader, which is confusing. So is there a downside to making it all consistent?

@sgratzl
Copy link
Member Author

sgratzl commented Sep 28, 2021

2\. Breadcrumbs.  I think of it this way: a user would land on Delphi and click the About menu and see a bunch of menu items.  And if they clicked on About Delphi or Blog then I would think I'm navigating no differently then if I clicked on Our Team.  (Even is the URL structure was different.)  But as a user I see different things happen with the subheader, which is confusing.  So is there a downside to making it all consistent?

blog should now also have the proper breadcrumb. Pages without breadcrumbs are the www-covidcast related pages, since from a layout point of view it doesn't fit there atm.

1. Navigating between explore and indicator / explore a location / etc. within the COVIDcast dashboard. I don't think a back button at the top (or in the browser) is sufficient because it's not even clear to the user what subpages we have here.  They'd only be able to get to these subpages by clicking around on the dashboard itself.  Are there any other for ways we can display the substructure here to the user?   **EDIT:** To be clear all I'm looking for is a way somewhere that's visible (top of the page?) to select between "Explore a Location" and "Explore an Indicator" ---- just those two.

I would suggest to come back to that after we integrated the new upcombing major changes to www-covidcast.

@sgratzl sgratzl marked this pull request as ready for review September 28, 2021 12:28
@ryantibs
Copy link
Member

  1. Sure, sounds reasonable.
  2. Thanks.

@ryantibs
Copy link
Member

Small thing I noticed in case it's possible to fix before merging. If not, then this is not critical. When you decrease the browser width, the menu item "COVID-19" gets split up over two lines. This is a bit awkward because I think it would be more natural to split, for example, "Flu & Other Pathogens".

Screen Shot 2021-09-28 at 9 51 21 AM

@krivard
Copy link
Contributor

krivard commented Sep 29, 2021

We're going to put this PR on hold until after October 5

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Ryan says okay

@krivard
Copy link
Contributor

krivard commented Oct 12, 2021

@sgratzl fix conflicts pls

@sgratzl sgratzl self-assigned this Oct 13, 2021
@sgratzl
Copy link
Member Author

sgratzl commented Oct 13, 2021

@krivard I resolved the conflicts. However, netlfy didn't bulid the latest update: https://app.netlify.com/sites/cmu-delphi-main/deploys. I don't why. Please check and test the website again before merging

@krivard
Copy link
Contributor

krivard commented Oct 13, 2021

It seems to be showing that 8e93505 was indeed deployed; is that not what you see?

image

@krivard
Copy link
Contributor

krivard commented Oct 13, 2021

Double-checking with @ryantibs that you wanted Flu & Other Pathogens to have nothing on it:

image

@krivard krivard requested a review from ryantibs October 13, 2021 14:47
@ryantibs
Copy link
Member

ryantibs commented Oct 14, 2021

Yes, for now. After the menu restructuring merge, there are two TODO items (@krivard, if you can, please create two issues and assign them to me and Roni, respectively):

  1. [Ryan] Update the About COVIDcast page.
  2. [Roni] Write a similar overview for the Flu and Other Pathogens page.

@krivard krivard merged commit 4a07684 into dev Oct 18, 2021
@krivard krivard deleted the sgratzl/newmenu branch October 18, 2021 20:29
@krivard krivard mentioned this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants