fix pushing image tags #301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for cmu-delphi-main ready! Built with commit 0392bda |
krivard
reviewed
Apr 1, 2021
| echo "::set-output name=tag::$imageTag" | ||
| echo "::set-output name=repo::ghcr.io/${{ github.repository }}" | ||
| - name: Push Dev Tag | ||
| if: startsWith(github.ref, 'refs/heads/dev') |
There was a problem hiding this comment.
Does this mean we'll end up tagging twice if github.ref is 'refs/heads/main'?
There was a problem hiding this comment.
the image job runs anyhow just for main and dev
ah, nevermind
There was a problem hiding this comment.
the job runs for both main and dev and each will create its own docker tag. For dev, it is :dev for main it is :latest and :v${currentVersion}
krivard
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
didn't push the main/latest tag and there was a typo in the version tag one