Skip to content

Conversation

@sgratzl
Copy link
Member

@sgratzl sgratzl commented Mar 29, 2021

merges the definition of team members and authors to a unified structure.

shouldn't have any visual change

@sgratzl sgratzl requested a review from tildechris March 29, 2021 16:20
@sgratzl sgratzl self-assigned this Mar 29, 2021
@netlify
Copy link

netlify bot commented Mar 29, 2021

Deploy preview for cmu-delphi-main ready!

Built with commit 6424576

https://deploy-preview-290--cmu-delphi-main.netlify.app

@sgratzl sgratzl added the chore label Mar 29, 2021
Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Makes sense to not have to redefine group members in both places. The only thing I can think of that may be confusing is 3rd party blog authors and needing to add them (and why) to the index.md with the blog attribute. Maybe add another sentence to the template post?

@sgratzl
Copy link
Member Author

sgratzl commented Mar 30, 2021

Maybe add another sentence to the template post?

actually you mark them as external: true such that they are not counted in the team page

@sgratzl
Copy link
Member Author

sgratzl commented Mar 30, 2021

re why:

for the "about the author" line at the bottom of the blog post. In case we wanna do #192. Otherwise, we could refactor it to have those external people inline

@tildechris
Copy link
Contributor

This makes sense, you can merge. My point was that we should document how this works. I had to look around for a bit on why why blog author names were not just strings (as you mention, the about this author section gets updated).

@sgratzl sgratzl merged commit 50516b5 into dev Mar 30, 2021
@sgratzl sgratzl deleted the sgratzl/people branch March 30, 2021 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants