-
Notifications
You must be signed in to change notification settings - Fork 7
unify people definition #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
inline collaborator
and add get-person and get-person helpers
sisters section cdc special thank research paper
|
Deploy preview for cmu-delphi-main ready! Built with commit 6424576 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Makes sense to not have to redefine group members in both places. The only thing I can think of that may be confusing is 3rd party blog authors and needing to add them (and why) to the index.md with the blog attribute. Maybe add another sentence to the template post?
actually you mark them as |
|
re why: for the "about the author" line at the bottom of the blog post. In case we wanna do #192. Otherwise, we could refactor it to have those external people inline |
|
This makes sense, you can merge. My point was that we should document how this works. I had to look around for a bit on why why blog author names were not just strings (as you mention, the about this author section gets updated). |
merges the definition of team members and authors to a unified structure.
shouldn't have any visual change