-
Notifications
You must be signed in to change notification settings - Fork 3
Upgrade EpiVis dashboard #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 10 commits
1d5df9c
ec3bfdb
35616b4
2affbc7
cce8598
b03faab
9358b84
640b4cc
7fd07f8
d48e3b0
9314d2c
111a19e
3bdcb6d
9bdb378
5f500ed
ffb46a5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,12 +1,14 @@ | ||||||
| <script lang="ts"> | ||||||
| import DataSet from '../../data/DataSet'; | ||||||
| import type { DataGroup } from '../../data/DataSet'; | ||||||
| import type { IChart } from '../store'; | ||||||
| import { expandedDataGroups } from '../../store'; | ||||||
| import TreeLeafNode from './TreeLeafNode.svelte'; | ||||||
| import Fa from 'svelte-fa'; | ||||||
| import { faChevronRight, faChevronDown } from '@fortawesome/free-solid-svg-icons'; | ||||||
| export let node: DataGroup; | ||||||
| export let chart: IChart | null; | ||||||
| function toggleExpanded() { | ||||||
| if (expanded) { | ||||||
|
|
@@ -28,7 +30,7 @@ | |||||
| {#if expanded} | ||||||
| {#each node.datasets as child (child.title)} | ||||||
| {#if child instanceof DataSet} | ||||||
| <TreeLeafNode node={child} /> | ||||||
| <TreeLeafNode {chart} node={child} /> | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. plz name attribute/arg for clarity
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Svelte linter actually reverts this change when I try to apply it :) I could disable this in the config, but shorthand attributes like this show up a lot in the code base, e.g. a couple lines before: and elsewhere: So I think it might be fairly clear what's going on with these.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. i dont love it, but if thats the preferred style in Svelte, we might as well go with it. |
||||||
| {:else} | ||||||
| <svelte:self node={child} /> | ||||||
| {/if} | ||||||
|
|
||||||
Uh oh!
There was an error while loading. Please reload this page.