Skip to content

refactor+clean: simplify package internals and clean configs #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Jul 15, 2024
Merged

refactor+clean: simplify package internals and clean configs #28

merged 19 commits into from
Jul 15, 2024

Conversation

@dshemetov
Copy link
Contributor

@dshemetov dshemetov commented May 7, 2024 •
edited
Loading

Working on #9

  • update ci actions
  • run through formatter with line-length=120
  • fix Sphinx docs and make some docs edits
  • unify build and tooling config in pyproject.toml
  • simplify imports in __init__.py
  • update and fix function type inconsistencies
  • remove some bloat functions
  • improve date handling in EpiRange and pub_covid_hosp_facility collection_weeks argument
  • remove async functionality, see Do we need to support async requests? #30
  • focus EpidataCall on DataFrames
    • default to DataFrame
    • remove format_type, always request classic, transform to DataFrame
    • parse types row by row only for classic(), otherwise let Pandas do it
    • consolidate DataFrame construction code to a single place (since async doesn't reuse it)
    • remove json, csv, and iter formats from EpidataCall object (uncommon and slow formats)

@dshemetov dshemetov mentioned this pull request Jul 10, 2024
Closed
@dshemetov dshemetov changed the title docs: make Sphinx buildable build+docs+refactor: make Sphinx docs buildable, unify build config, lint, and remove async functionality Jul 10, 2024
@dshemetov dshemetov changed the title build+docs+refactor: make Sphinx docs buildable, unify build config, lint, and remove async functionality build+ci+docs+refactor: make Sphinx docs buildable, unify build config, lint, and remove async functionality Jul 10, 2024
@dshemetov dshemetov changed the title build+ci+docs+refactor: make Sphinx docs buildable, unify build config, lint, and remove async functionality refactor+clean: simplify package internals and clean configs Jul 10, 2024
@dshemetov dshemetov force-pushed the ds/fixup branch 2 times, most recently from 3e8ab87 to 481d216 Compare July 10, 2024 23:22
@dshemetov
refactor: center DataFrame return in EpidataCall
03bc328 
* remove json, csv, iter formats
* remove format_type option, always request classic
* consolidate DataFrame code
* parse types only if classic, otherwise let Pandas do it
@dshemetov dshemetov merged commit 9584e18 into dev Jul 15, 2024
@dshemetov dshemetov deleted the ds/fixup branch July 15, 2024 20:00
@dshemetov dshemetov mentioned this pull request Jul 16, 2024
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dshemetov