Skip to content

Conversation

dshemetov
Copy link
Contributor

@dshemetov dshemetov commented Feb 28, 2022

Part of fixing cmu-delphi/covidcast-indicators#1520. This should be merged first, as it will be a no-op (aside from a memory usage increase on the acquisition server). Then we can merge the archivediffer fix (upcoming).

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Allows NAs in missing columns, so the validation can fix them. This will allow archive differ to easily add deletion codes, not have to do any validation on the rest of the missing codes, and let the validation here in acquisition take care of it.

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@krivard krivard merged commit 9dfdf52 into dev Feb 28, 2022
@krivard krivard deleted the ds/archive-differ-fix branch February 28, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants