Skip to content

fix: timepair for week values not working #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2021
Merged

fix: timepair for week values not working #668

merged 1 commit into from
Aug 5, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Aug 5, 2021

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

fixes https://api.covidcast.cmu.edu/epidata/covidcast/?signal=nchs-mortality%3Adeaths_allcause_incidence_prop&geo=state%3Apa&time=week%3A202114-202120 server error

bug was the the index guess logic didn't take weekly signals into account

@sgratzl sgratzl added the bug label Aug 5, 2021
@sgratzl sgratzl requested a review from krivard August 5, 2021 16:15
@sgratzl sgratzl self-assigned this Aug 5, 2021
@sgratzl sgratzl added the api change affect the API and its responses label Aug 5, 2021
krivard
krivard approved these changes Aug 5, 2021
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@sgratzl sgratzl merged commit 16e8b42 into dev Aug 5, 2021
@sgratzl sgratzl deleted the sgratzl/weekparser branch August 5, 2021 17:55
@sgratzl sgratzl restored the sgratzl/weekparser branch August 5, 2021 17:56
@sgratzl sgratzl mentioned this pull request Aug 5, 2021
Merged
4 tasks
sgratzl added a commit that referenced this pull request Aug 5, 2021
@sgratzl
Merge pull request #669 from cmu-delphi/sgratzl/weekparser
6f8cee8 
fix: fix tests for merging #668
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krivard krivard krivard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sgratzl sgratzl

Labels

api change affect the API and its responses bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sgratzl @krivard