Skip to content

style(tests): format many tests with black #1219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 10, 2023
Merged

style(tests): format many tests with black #1219

merged 7 commits into from
Jul 10, 2023

Conversation

@dshemetov
Copy link
Contributor

Part of #962

Summary:

  • Runs the tests and a few common dir files through black
  • Holds off on covid_hosp and covidcast until the PRs on those are merged

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@dshemetov dshemetov requested a review from krivard June 28, 2023 19:31
krivard
krivard reviewed Jun 29, 2023
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

largely good, one item to revert

@dshemetov dshemetov requested a review from krivard July 10, 2023 19:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 10, 2023 •
edited
Loading

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

krivard
krivard approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dshemetov dshemetov merged commit f7a279b into dev Jul 10, 2023
@dshemetov dshemetov deleted the ds/format-tests branch July 10, 2023 20:21
@dsweber2 dsweber2 mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@krivard krivard krivard approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dshemetov @krivard