Skip to content

Conversation

@dshemetov
Copy link
Contributor

closes #1141

Summary:

  • Remove afhsb endpoint from acquisition, server, and clients

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

@dshemetov dshemetov requested a review from melange396 June 23, 2023 21:57
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there are still mentions of 'afhsb' in: deploy.json, docs/api/README.md, dev/local/setup.cfg, src/client/delphi_epidata.js, and src/client/delphi_epidata.d.ts

and afhsb doc files can probably be deleted: docs/api/afhsb.md, and docs/api/meta_afhsb.md

also, in the prod database, there is also a 'user role' for 'afhsb' and an associated legacy auth key, and an (empty) dmisid_table table. i can zap those too.

@dshemetov
Copy link
Contributor Author

Thank you, I did a Ctrl + F for afhsb, but forgot I had a Python-only filter applied.

@dshemetov dshemetov requested a review from melange396 June 24, 2023 01:35
Copy link
Collaborator

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, RIP

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dshemetov dshemetov merged commit 7fd6a90 into dev Jun 26, 2023
@dshemetov dshemetov deleted the ds/del-afhsb branch June 26, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Disable/remove afhsb endpoint

2 participants