Skip to content

Conversation

rzats
Copy link
Contributor

@rzats rzats commented Feb 27, 2023

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

Updates the performance testing rig to make its PR comment output a summary of the run, which looks like this:

Screenshot 2023-02-27 at 21 33 08

@rzats rzats requested review from krivard and melange396 and removed request for melange396 February 27, 2023 19:39
@rzats
Copy link
Contributor Author

rzats commented Feb 27, 2023

Unsure if this will trigger the newer or older version of the GitHub Action, but:

/run performance test

E: nope, looks like the older version for now

@github-actions
Copy link
Contributor

✅ Performance tests complete! Click here to view results: https://github.com/cmu-delphi/delphi-epidata/actions/runs/4286183094

krivard
krivard previously approved these changes Feb 28, 2023
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Can merge as-is; question identifies a possible opportunity to reduce some coupling

@rzats
Copy link
Contributor Author

rzats commented Mar 1, 2023

@krivard requesting a re-review since I applied the change that reduced some repetitive code

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Solid!

@rzats rzats merged commit b877dbc into dev Mar 1, 2023
@rzats rzats deleted the rzatserkovnyi/performance-testing-rig-output branch March 1, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants