Skip to content

Update covid_hosp endpoint documentation with August 2022 limitations #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 28, 2022
Merged

Update covid_hosp endpoint documentation with August 2022 limitations #1008

merged 4 commits into from
Oct 28, 2022

Conversation

@krivard
Copy link
Contributor

@krivard krivard commented Oct 20, 2022 •
edited
Loading

Prerequisites:

  • Unless it is a documentation hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

  • describe forward-fill and annual reporting limitations
  • link to HHS FAQ, which has better information on all fields
  • correct the output documentation for facility lookup

@krivard
Update covid_hosp endpoint documentation
4fff03c 
* describe forward-fill and annual reporting limitations
* correct output documentation for facility lookup
* link to HHS FAQ, which has better information on all fields
@krivard krivard requested a review from brookslogan October 20, 2022 21:07
brookslogan
brookslogan requested changes Oct 27, 2022
View reviewed changes
@krivard
Add suggestions from code review
e88ecb8
@krivard
Update facility-wise data dictionary link
40b073f
@krivard
Correct data dictionary sync date.
9d97492 
(it really was october 2021; the next sync will add the ~20 columns we've been dropping on the floor since January/April 2022)
@krivard krivard requested a review from brookslogan October 27, 2022 21:22
brookslogan
brookslogan approved these changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@brookslogan brookslogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Note that I haven't done any check on the description of the 2021-10-21 repair.

@krivard krivard merged commit f9be532 into dev Oct 28, 2022
@krivard krivard deleted the krivard/covid_hosp-docs-update branch October 28, 2022 20:02
This was referenced Nov 3, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brookslogan brookslogan brookslogan approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krivard @brookslogan