Skip to content

Make sure GitHub date-request errors are raised #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 29, 2023
Merged

Make sure GitHub date-request errors are raised #658

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f02f78b
error on other bad http status codes
nmdefries Aug 24, 2023
2a7bca9
drop try-catch when fetching dates so we get http errors
nmdefries Aug 24, 2023
9bf9404
do intersection date conversion only if has contents
nmdefries Aug 24, 2023
5b58660
bump version and describe changes in NEWS
nmdefries Aug 25, 2023
b91cc61
wrap date requests in RETRY
nmdefries Aug 28, 2023
abd3a6f
bump version in DESCRIPTION
nmdefries Aug 28, 2023
157f022
Merge branch 'main' into ndefries/forward-gh-request-errors
nmdefries Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions R-packages/evalcast/R/get_covidhub_predictions.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,11 +151,7 @@ get_forecast_dates <- function(forecasters,
forecast_dates <- as_date(forecast_dates)
forecaster_dates <- vector("list", length = length(forecasters))
for (i in seq_len(length(forecasters))) {
forecaster_dates[[i]] <- tryCatch({
lubridate::as_date(get_covidhub_forecast_dates(forecasters[i]))
},
error = function(e) cat(sprintf("%i. %s\n", i, e$message))
)
forecaster_dates[[i]] <- lubridate::as_date(get_covidhub_forecast_dates(forecasters[i]))
Copy link
Collaborator

@dshemetov dshemetov Aug 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly out of scope, but if you know off the top of your head, im curious: why are we using lubridate here instead of just as_date?

Copy link
Contributor Author

@nmdefries nmdefries Aug 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. (All the other as_dates should really be loading directly from lubridate since we're not importing the function.)

}
if (length(forecast_dates) != 0) {
# Intersect acts oddly with dates. If foo = as_date(bar), then foo == bar is
Expand Down