Skip to content

Conversation

SimonFrings
Copy link
Contributor

@SimonFrings SimonFrings commented Aug 2, 2021

This changeset simplifies usage by supporting the new default loop.

// old (still supported)
$launcher = new Clue\React\Shell\ProcessLauncher($loop);

// new (using default loop)
$launcher = new Clue\React\Shell\ProcessLauncher();

Builds on top of reactphp/event-loop#226, reactphp/event-loop#229, reactphp/event-loop#232, reactphp/child-process#87 and reactphp/stream#159

@clue clue added this to the v0.3.0 milestone Aug 3, 2021
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants