Skip to content

Conversation

SimonFrings
Copy link
Contributor

@SimonFrings SimonFrings commented Dec 8, 2020

PHPUnit 9.3 released a new schema for the phpunit.xml configuration file. I had to migrate the file to the new format in order to avoid the warning. PHPUnit Versions older than 9.3 have to use the phpunit.xml.legacy configuration file, because the new format is unknown for them.
For further details concerning this pull request look into graphp/graphviz#46.
This pull request builds on top of #13.

It's also possible to run this code with PHP 8 🎉

$ docker run -it --rm -v `pwd`:/data --workdir=/data php:8.0 php vendor/bin/phpunit
PHPUnit 9.5.0 by Sebastian Bergmann and contributors.

............................................                      44 / 44 (100%)

Time: 00:00.006, Memory: 6.00 MB

OK (44 tests, 47 assertions)

@clue clue added this to the v2.1.0 milestone Dec 8, 2020
Copy link
Owner

@clue clue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonFrings Thanks for the update, changes LGTM! :shipit:

@clue clue merged commit ff9cdac into clue:master Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants