Skip to content

Conversation

@bkero
Copy link

@bkero bkero commented Nov 28, 2023

what

Allows an existing parameter group to be specified. This is useful for cases where you simply want to use an existing parameter group (such as default.redis7), or when a parameter group is handled in other places within Terraform.

why

We have some clusters which are using existing parameter groups who's management is out of scope for this module. We would like to use them with clusters deployed using this module.

references

@bkero bkero requested review from a team as code owners November 28, 2023 23:03
@bkero bkero force-pushed the add-existing-param-group branch from 348ed11 to 6aaf21b Compare November 28, 2023 23:20
@y3ti
Copy link
Contributor

y3ti commented Nov 29, 2023

Duplicated #208

@bkero
Copy link
Author

bkero commented Nov 29, 2023

Duplicated #208

Hey there. I just read #208 and it that it has a similar goal, although still enforces creation of a parameter group. The impetus for this pull request is to allow an already-existing parameter group to be specified. If you look at the count metaparameter of the parameter_group resource, you'll see that I'm preventing the creation if a name is specified.

@y3ti
Copy link
Contributor

y3ti commented Nov 29, 2023

@bkero ach ok, you are right. Thank you for explaining it once more :)

What if we have a new variable create_parameter_group? If the variable's value is set to false then the parameter group won't be created. If set to true then the new parameter group will be created with the name set to ${parameter_group_name}. This approach allows us to address both scenarios effectively.

@bkero
Copy link
Author

bkero commented Nov 29, 2023

@bkero ach ok, you are right. Thank you for explaining it once more :)

What if we have a new variable create_parameter_group? If the variable's value is set to false then the parameter group won't be created. If set to true then the new parameter group will be created with the name set to ${parameter_group_name}. This approach allows us to address both scenarios effectively.

Yes I would find that perfectly satisfactory. It would allow me to use the default default.redis7 parameter group.

I can create a follow-up PR once #208 merges.

@y3ti
Copy link
Contributor

y3ti commented Nov 30, 2023

@bkero I added the new variable create_parameter_group to my PR: #208 (comment)

@hans-d hans-d added the stale This PR has gone stale label Mar 2, 2024
@hans-d hans-d closed this Mar 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This PR has gone stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants