Skip to content

Add working example #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 20, 2018
Merged

Add working example #17

merged 7 commits into from
Jul 20, 2018

Conversation

@osterman
Copy link
Member

@osterman osterman commented Jul 20, 2018 •
edited
Loading

@osterman osterman self-assigned this Jul 20, 2018
@osterman
Copy link
Member Author

osterman commented Jul 20, 2018 •
edited
Loading

terraform apply results in a different error than reported by customer.

Error: Error applying plan:

1 error(s) occurred:

* module.redis.aws_elasticache_replication_group.default: 1 error(s) occurred:

* aws_elasticache_replication_group.default: Error creating Elasticache Replication Group: InvalidParameterValue: SNS topic is either invalid or it doesn't belong to the customer account:10000000
	status code: 400, request id: 912cdaeb-8bb4-11e8-8819-17e181b6cff4

Terraform does not automatically rollback in the face of errors.
Instead, your Terraform state file has been partially updated with
any resources that successfully completed. Please address the error
above and apply again to incrementally change your infrastructure.

This was caused by #13 (comment) which is now fixed

@osterman osterman requested review from aknysh and sarkis July 20, 2018 01:34
aknysh
aknysh reviewed Jul 20, 2018
View reviewed changes
examples/simple/main.tf Outdated

module "subnets" {
source = "git::https://github.com/cloudposse/terraform-aws-dynamic-subnets.git?ref=tags/0.3.5"
namespace = "eg"
Copy link
Member

@aknysh aknysh Jul 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"${var.namespace}"?

should not mix the hardcoded values with variables.
we have namespace, stage and name vars.
and all other attributes are set from vars.

aknysh
aknysh reviewed Jul 20, 2018
View reviewed changes
Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

inline comments

@osterman osterman merged commit fcb1504 into master Jul 20, 2018
@osterman osterman deleted the add-example branch July 20, 2018 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aknysh aknysh aknysh approved these changes

+1 more reviewer

@sarkis sarkis sarkis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@osterman osterman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@osterman @sarkis @aknysh