Small fixes - convert param values to string, set auto failover to true if cluster enabled #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
requested review from
jhosteny and
milldr
and removed request for
a team
|
/test all |
korenyoni
approved these changes
Dec 14, 2021
brian-weis-msr
pushed a commit
to Measurabl/terraform-aws-elasticache-redis
that referenced
this pull request
Apr 2, 2024
…ue if cluster enabled (cloudposse#141) * added description on resources aws_elasticache_subnet_group and aws_elasticache_parameter_group * Convert param values to strings * Set auto failover to true if cluster mode enabled * make github/init Co-authored-by: Simone Ferraro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
why
Param values will fail if they are not strings
Auto failover needs to be set to true if cluster mode is enabled or it will fail with an error
references