Skip to content

Init #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Aug 9, 2017
Merged

Init #1

merged 27 commits into from
Aug 9, 2017

Conversation

@goruha
Copy link
Member

@goruha goruha commented Aug 8, 2017 •
edited by osterman
Loading

What

  • Added redis failover cluster based on aws elasticache

Why

  • Redis is a popular storage/cache backend that offers more advanced data structures than Memcache

@goruha goruha requested a review from osterman August 8, 2017 20:57
osterman
osterman reviewed Aug 8, 2017
View reviewed changes
main.tf Outdated


module "dns" {
source = "git::https://github.com/cloudposse/tf_hostname.git"
Copy link
Member

@osterman osterman Aug 8, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets tag & pin.

Copy link
Member Author

@goruha goruha Aug 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@osterman
Copy link
Member

osterman commented Aug 8, 2017 •
edited by goruha
Loading

  • Fix LICENSE copyright.
  • Update README.md with usage

osterman
osterman requested changes Aug 8, 2017
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

@goruha
Copy link
Member Author

goruha commented Aug 9, 2017 •
edited by osterman
Loading

Fix LICENSE copyright.

What is this about?

@osterman
Copy link
Member

osterman commented Aug 9, 2017

https://github.com/cloudposse/tf_redis/blob/master/LICENSE#L189

osterman
osterman reviewed Aug 9, 2017
View reviewed changes
README.md Outdated

| Name | Default | Decription |
|:------:|:---------:|:------------:|
| namespace|global|Namespace|
Copy link
Member

@osterman osterman Aug 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spacing?

@goruha goruha merged commit e513149 into master Aug 9, 2017
@goruha goruha deleted the init branch August 9, 2017 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@osterman osterman osterman approved these changes

Assignees

@osterman osterman

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@goruha @osterman