-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Chart Labels #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughPre-commit config now excludes YAML files under any templates directories from YAML checks. The Helm chart for echo-server’s Deployment template conditionally renders user-provided labels under the pod template metadata when .Values.labels is set. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Helm as Helm Template Engine
participant K8s as Kubernetes API
User->>Helm: helm install/upgrade with values.yaml
alt Values include labels
Helm->>Helm: Render Deployment\n+ include .Values.labels under spec.template.metadata.labels
else No labels provided
Helm->>Helm: Render Deployment\n+ default labels only
end
Helm->>K8s: Apply rendered manifests
K8s-->>User: Deployment created/updated
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/terratest |
|
These changes were released in v1.537.0. |
what
why
var.chart_valuesreferences
Summary by CodeRabbit
New Features
Chores