Skip to content

Conversation

@milldr
Copy link
Contributor

@milldr milldr commented Oct 10, 2025

what

  • Added chart labels, optional
  • Dont YAML check helm charts

why

  • We want to optionally add chart labels if included var.chart_values

references

  • .

Summary by CodeRabbit

  • New Features

    • Echo Server chart now supports user-provided labels in the Deployment’s pod template, enabling easier integration with organizational policies and tagging workflows.
  • Chores

    • Updated pre-commit configuration to skip YAML checks for templated files, reducing false positives in Helm templates and improving developer workflow reliability.

@milldr milldr requested a review from a team as a code owner October 10, 2025 16:33
@milldr milldr added the minor New features that do not break anything label Oct 10, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 10, 2025

Walkthrough

Pre-commit config now excludes YAML files under any templates directories from YAML checks. The Helm chart for echo-server’s Deployment template conditionally renders user-provided labels under the pod template metadata when .Values.labels is set.

Changes

Cohort / File(s) Summary of Changes
Pre-commit config exclusions
.pre-commit-config.yaml
Added exclude regex to skip YAML files under any templates directories (e.g., Helm templates) from YAML lint/check hooks. No other hook changes.
Helm chart templating: optional labels
src/charts/echo-server/templates/deployment.yaml
Added conditional rendering of .Values.labels into spec.template.metadata.labels, merging user-provided labels into the pod template when present.

Sequence Diagram(s)

sequenceDiagram
  participant User
  participant Helm as Helm Template Engine
  participant K8s as Kubernetes API

  User->>Helm: helm install/upgrade with values.yaml
  alt Values include labels
    Helm->>Helm: Render Deployment\n+ include .Values.labels under spec.template.metadata.labels
  else No labels provided
    Helm->>Helm: Render Deployment\n+ default labels only
  end
  Helm->>K8s: Apply rendered manifests
  K8s-->>User: Deployment created/updated
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

I thump my paws—commit hooks hop past,
Templates whisper, “labels at last!”
YAML winds avoid the templated trail,
While pods wear tags upon their tail.
Carrot-green keys, value fields bright—
Charts bloom tidy in the moonlit night. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly captures the primary change of the pull request—introducing optional chart labels—using a clear conventional commit style and avoiding extraneous details. It aligns with the main objective of the changeset without overloading the reader with secondary implementation specifics.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat/labels

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3df43fd and 40e6a41.

📒 Files selected for processing (2)
  • .pre-commit-config.yaml (1 hunks)
  • src/charts/echo-server/templates/deployment.yaml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Summary
🔇 Additional comments (1)
src/charts/echo-server/templates/deployment.yaml (1)

19-21: Conditional label rendering looks good.

Scope reset via with plus toYaml/nindent keeps indentation clean and only emits user labels when provided—nice touch.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mergify mergify bot requested review from a team October 10, 2025 16:34
@milldr
Copy link
Contributor Author

milldr commented Oct 10, 2025

/terratest

@milldr milldr enabled auto-merge October 10, 2025 16:47
@milldr milldr added this pull request to the merge queue Oct 14, 2025
Merged via the queue into main with commit 8ae2916 Oct 14, 2025
19 checks passed
@milldr milldr deleted the feat/labels branch October 14, 2025 13:39
@github-actions
Copy link

These changes were released in v1.537.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

minor New features that do not break anything

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants