Skip to content

fix: Exclude Name tag to prevent ALB conflicts #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2025
Merged

fix: Exclude Name tag to prevent ALB conflicts #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,3 +76,4 @@ github/
*.ovpn

*.zip
account-map/
15 changes: 9 additions & 6 deletions src/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ locals {

create_namespace = local.enabled && var.create_namespace

kubernetes_namespace = local.create_namespace ? join("", kubernetes_namespace.default.*.id) : var.kubernetes_namespace
kubernetes_namespace = local.create_namespace ? join("", kubernetes_namespace.default[*].id) : var.kubernetes_namespace

kubernetes_service_enabled = local.enabled && var.kubernetes_service_enabled

Expand All @@ -24,17 +24,20 @@ locals {

ingress_controller_group_name = try(coalesce(var.alb_group_name, module.this.name), module.this.name)

kube_tags = join(",", [for k, v in module.this.tags : "${k}=${v}"])
# Exclude "Name" tag to avoid conflicts with ALB controller's IngressClassParams
# The ALB controller applies its own "Name" tag via IngressClassParams, and having
# conflicting "Name" tags prevents the ALB from being created/updated properly
kube_tags = join(",", [for k, v in { for key, value in module.this.tags : key => value if key != "Name" } : "${k}=${v}"])

default_rule = "default-404-rule"

message_body = templatefile(var.fixed_response_template, var.fixed_response_vars)

# for outputs
annotations = try(kubernetes_ingress_v1.default[0].metadata.0.annotations, null)
group_name_annotation = try(lookup(kubernetes_ingress_v1.default[0].metadata.0.annotations, "alb.ingress.kubernetes.io/group.name", null), null)
scheme_annotation = try(lookup(kubernetes_ingress_v1.default[0].metadata.0.annotations, "alb.ingress.kubernetes.io/scheme", null), null)
class_annotation = try(lookup(kubernetes_ingress_v1.default[0].metadata.0.annotations, "kubernetes.io/ingress.class", null), null)
annotations = try(kubernetes_ingress_v1.default[0].metadata[0].annotations, null)
group_name_annotation = try(lookup(kubernetes_ingress_v1.default[0].metadata[0].annotations, "alb.ingress.kubernetes.io/group.name", null), null)
scheme_annotation = try(lookup(kubernetes_ingress_v1.default[0].metadata[0].annotations, "alb.ingress.kubernetes.io/scheme", null), null)
class_annotation = try(lookup(kubernetes_ingress_v1.default[0].metadata[0].annotations, "kubernetes.io/ingress.class", null), null)
load_balancer_name = one(data.aws_lb.default[*].name)
host = join(".", [module.this.environment, module.dns_delegated.outputs.default_domain_name])
}
Expand Down
Loading