Skip to content

feat: DEVX-17479-Allow-analytics-feature-flag-override #605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2025
+10 −5
Merged

feat: DEVX-17479-Allow-analytics-feature-flag-override #605

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions __TESTS_BUNDLE_SIZE__/bundleSizeTestCases.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const bundleSizeTestCases:ITestCase[] = [
},
{
name: 'Tests CloudinaryImage with Resize and Adjust',
sizeLimitInKB: 33,
sizeLimitInKB: 34,
importsArray: [
importFromDist('assets/CloudinaryImage', 'CloudinaryImage'),
importFromDist('instance/Cloudinary', 'Cloudinary'),
Expand All @@ -34,7 +34,7 @@ const bundleSizeTestCases:ITestCase[] = [
},
{
name: 'Tests CloudinaryImage with Resize, Adjust and Border',
sizeLimitInKB: 34,
sizeLimitInKB: 35,
importsArray: [
importFromDist('assets/CloudinaryImage', 'CloudinaryImage'),
importFromDist('instance/Cloudinary', 'Cloudinary'),
Expand All @@ -45,7 +45,7 @@ const bundleSizeTestCases:ITestCase[] = [
},
{
name: 'Tests CloudinaryImage image with Resize, adjust and delivery',
sizeLimitInKB: 35,
sizeLimitInKB: 36,
importsArray: [
importFromDist('assets/CloudinaryImage', 'CloudinaryImage'),
importFromDist('instance/Cloudinary', 'Cloudinary'),
Expand Down Expand Up @@ -74,7 +74,7 @@ const bundleSizeTestCases:ITestCase[] = [
},
{
name: 'Import all of the SDK',
sizeLimitInKB: 140,
sizeLimitInKB: 142,
importsArray: [
importFromPackage('* as CloudinaryURLGEN')
]
Expand All @@ -88,7 +88,7 @@ const bundleSizeTestCases:ITestCase[] = [
},
{
name: 'Import All Actions',
sizeLimitInKB: 65,
sizeLimitInKB: 67,
importsArray: [
importFromPackage('Actions')
]
Expand Down
4 changes: 4 additions & 0 deletions src/sdkAnalytics/getAnalyticsOptions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,9 @@ export function getAnalyticsOptions(options: ITrackedPropertiesThroughAnalytics)
analyticsOptions.feature = 'B';
}

if (options.feature) {
analyticsOptions.feature = options.feature;
}

return analyticsOptions;
}
1 change: 1 addition & 0 deletions src/sdkAnalytics/interfaces/ITrackedPropertiesThroughAnalytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,6 @@ export interface ITrackedPropertiesThroughAnalytics {
lazyload?: boolean; // Was lazy-load used
responsive?: boolean; // Was responsive used
placeholder?: boolean; // Was placeholder used
feature?: string;
}