Skip to content

fix: build fails on node 12 #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
5 commits merged into from
Aug 9, 2022
Merged

fix: build fails on node 12 #531

5 commits merged into from
Aug 9, 2022

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2022 •
edited by ghost
Loading

  • Update typescript version to fix error on node 12
  • Add missing parameters to npm scripts using ts-node
  • Fix the export of TEST_FILE_STRUCTURE - make it named instead of default
  • Fix bundle size min size comparison

@ghost ghost requested a review from strausr August 8, 2022 18:37
@ghost ghost changed the title fix: update typescript version to fix error on node 12 fix: build fails on node 12 Aug 8, 2022
@ghost ghost mentioned this pull request Aug 8, 2022
Merged
strausr
strausr reviewed Aug 9, 2022
View reviewed changes
@ghost ghost requested a review from strausr August 9, 2022 09:18
@ghost ghost merged commit 81229ac into master Aug 9, 2022
@ghost ghost deleted the fix/ts-error-node-12 branch August 9, 2022 10:02
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@strausr @nirmaoz