Add signature checking methods #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitzanj
reviewed
Dec 30, 2019
| return Long.toString(System.currentTimeMillis() / 1000L); | ||
| } | ||
|
|
||
| public static byte[] getUTF8Bytes(String string) { |
There was a problem hiding this comment.
Since this was made public we need documentation. Same goes for produceSignature below.
Please also document all new methods/classes (ApiResponseSignatureVerifier, NotificationRequestSignatureVerifier, etc).
| import com.cloudinary.utils.StringUtils; | ||
|
|
||
| class SigningUtils { | ||
| static String safeString(String str) { |
There was a problem hiding this comment.
This can be a method in StringUtils instead of a new SigningUtils file, as it's not really a signing issue (And may be used by other utils).
|
|
||
| @Test | ||
| public void testVerifySignatureFailWhenSignatureDoesntMatch() { | ||
| NotificationRequestSignatureVerifier impl = new NotificationRequestSignatureVerifier("someApiSecret"); |
There was a problem hiding this comment.
Why impl? should be called something more specific (e.g. verifier), there's no abstract/interface vs impl involved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.