Skip to content

Encode URLs in API calls #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 19, 2020
Merged

Encode URLs in API calls #186

merged 7 commits into from
Jan 19, 2020

Conversation

@michalkcloudinay
Copy link
Contributor

@michalkcloudinay michalkcloudinay commented Nov 25, 2019

No description provided.

@asisayag2 asisayag2 requested a review from nitzanj November 25, 2019 16:15
nitzanj
nitzanj suggested changes Nov 28, 2019
View reviewed changes
Copy link
Contributor

@nitzanj nitzanj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test relies on an existing folder, it breaks on the test clouds (and any fresh cloud). Please rewrite the test so it doesn't need any pre-existing state to pass

@michalkcloudinay michalkcloudinay changed the title "encode URL in API calls" Encode URLs in API calls Dec 5, 2019
@nitzanj nitzanj merged commit dc3c5f1 into master Jan 19, 2020
@nitzanj nitzanj deleted the fix/encode-url-in-admin-api-methods branch March 19, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nitzanj nitzanj nitzanj requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michalkcloudinay @nitzanj