Skip to content

Conversation

@colbyfayock
Copy link
Collaborator

@colbyfayock colbyfayock commented Sep 13, 2024

Description

Updates the TypeScript types to pull in textTracks to the CldVideoPlayer component, which opens up the ability to add captions and subtitles to videos.

This was technically already possible, as the option would be passed to the player, but the types may have prevented it.

Usage:

textTracks={{
  captions: {
      label: 'English',
      language: 'en',
      default: true,
      url: 'https://res.cloudinary.com/<Cloud Name>/raw/upload/<FileName>.vtt'
    }
  }
}}

This also pulls in changes to getCldImageUrl which adds a version number by default (v1). This is to improve the compatibility of getCldImageUrl with the parsing capabilities that require a version number.

Finally made a few TS config tweaks pulled over from: cloudinary-community/astro-cloudinary#8

Issue Ticket Number

Fixes #430
Fixes #515

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Fix or improve the documentation
  • This change requires a documentation update

Checklist

  • I have followed the contributing guidelines of this project as mentioned in CONTRIBUTING.md
  • I have created an issue ticket for this PR
  • I have checked to ensure there aren't other open Pull Requests for the same update/change?
  • I have performed a self-review of my own code
  • I have run tests locally to ensure they all pass
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes needed to the documentation

@vercel
Copy link

vercel bot commented Sep 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
next-cloudinary ✅ Ready (Inspect) Visit Preview Sep 13, 2024 3:09am

@colbyfayock colbyfayock changed the title Captions & Subtitles Captions & Subtitles, URL Default Version Sep 13, 2024
@colbyfayock colbyfayock changed the title Captions & Subtitles, URL Default Version Captions & Subtitles, URL Default Version, TS Config Tweaks Sep 13, 2024
@colbyfayock colbyfayock merged commit 386c74d into main Sep 13, 2024
@colbyfayock colbyfayock deleted the feat/430+515-captions branch September 13, 2024 03:23
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
# [6.13.0](v6.12.0...v6.13.0) (2024-09-13)

### Features

* Captions & Subtitles, URL Default Version, TS Config Tweaks ([#517](#517)) ([386c74d](386c74d)), closes [#430](#430) [#515](#515)
@github-actions
Copy link

🎉 This PR is included in version 6.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] Caption for CldVideoPlayer component CldVideoPlayer Captions

2 participants