Ensure LIMITED_METRICS val is interpreted as bool #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit ensures that users will not encounter the following error
while deploying `system-metrics` on Windows stemcells:
```
Task 14 | 03:07:40 | L starting jobs: no_op/fb4da847-c87e-4532-9cce-9ae174d9520d (0) (canary) (00:00:30)
L Error: Action Failed start: Configuring jobs: Configuring job loggr-system-metrics-agent-windows: Adding monit configuration: json: cannot unmarshal bool into Go value of type string
Task 14 | 03:07:41 | Error: Action Failed start: Configuring jobs: Configuring job loggr-system-metrics-agent-windows: Adding monit configuration: json: cannot unmarshal bool into Go value of type string
```
This was brought to our attention via a trouble report in an internal
Slack channel.
Signed-off-by: Ben Fuller <[email protected]>
|
We have created an issue in Pivotal Tracker to manage this. Unfortunately, the Pivotal Tracker project is private so you may be unable to view the contents of the story. The labels on this github issue will be updated when the story is started. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit ensures that users will not encounter the following error while deploying
system-metricson Windows stemcells:This was brought to our attention via a trouble report in an internal Slack channel.
Signed-off-by: Ben Fuller [email protected]
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch