Upgrade gopsutil to v3 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 29, 2022
ctlong
force-pushed
the
upgrade-gopsutil-to-v3
branch
2 times, most recently
from
3ad1f8c to
4ffb0b7
Compare
* Upgrade `github.com/shirou/gopsutil` to v3. * Stop pinning golang.org/x/sys. * They seem to have some codependency such that no go tools on mac we were working without them both being updated.
ctlong
force-pushed
the
upgrade-gopsutil-to-v3
branch
from
4ffb0b7 to
bef304e
Compare
Benjamintf1
approved these changes
Jul 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
github.com/shirou/gopsutilto v3.golang.org/x/sys.golang.org/x/syswas pinned, so I think it's fair to assume that it was only pinned because of gopsutil.Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch