Skip to content

Add dependabot for tests #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 8, 2022
Merged

Add dependabot for tests #81

merged 4 commits into from
Aug 8, 2022

Conversation

@ctlong
Copy link
Member

@ctlong ctlong commented Jul 15, 2022

Keep the acceptance tests dependencies up-to-date.

Drive-bys:

  • Bump go minimum version for that module to go1.17.
  • Bump to ginkgo v2.

@ctlong ctlong marked this pull request as ready for review July 15, 2022 22:45
Benjamintf1
Benjamintf1 previously approved these changes Jul 16, 2022
View reviewed changes
@ctlong ctlong requested a review from Benjamintf1 July 18, 2022 16:29
@ctlong
Copy link
Member Author

ctlong commented Jul 18, 2022

The default timeout of 1h in ginkgo v2 wasn't enough for CI (ginkgo v1 had a default timeout of 24h). Updated the test script to include a new timeout of 2h.

Benjamintf1
Benjamintf1 previously approved these changes Jul 18, 2022
View reviewed changes
@ctlong
Update scripts/test
2453c5a 
* Install the ginkgo v2 CLI based on the version in tests.
* Use ginkgo v2 flags.
* Set the default timeout to 2h so that tests pass. The default timeout
  in ginkgo v1 was 24h.

See
[here](https://onsi.github.io/ginkgo/#recommended-continuous-integration-configuration)
for more information.
@ctlong ctlong force-pushed the add-dependabot-for-tests branch from 97ba584 to 2453c5a Compare July 18, 2022 19:02
@ctlong ctlong requested a review from Benjamintf1 July 18, 2022 19:02
@ctlong
Copy link
Member Author

ctlong commented Jul 18, 2022

Updated the test script to actually use the ginkgo v2 CLI 😅

@Benjamintf1
Copy link
Member

Benjamintf1 commented Jul 18, 2022

Any reason we're go installing ginkgo as opposed to go running like our other pipes?

@ctlong
Copy link
Member Author

ctlong commented Jul 18, 2022

None except that's the way we were doing it before. Would you like me to change it?

@bosh-admin-bot
Copy link

bosh-admin-bot commented Aug 8, 2022

This pull request was marked as Stale because it has been open for 21 days without any activity. If no activity takes place in the coming 7 days it will automatically be close. To prevent this from happening remove the Stale label or comment below.

@ctlong ctlong removed the Stale label Aug 8, 2022
@ctlong ctlong merged commit 13f2eac into main Aug 8, 2022
@ctlong ctlong deleted the add-dependabot-for-tests branch August 8, 2022 21:29
@ctlong ctlong mentioned this pull request Oct 6, 2022
Merged
@ctlong ctlong mentioned this pull request Oct 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Benjamintf1 Benjamintf1 Benjamintf1 approved these changes

@acrmp acrmp Awaiting requested review from acrmp

@rroberts2222 rroberts2222 Awaiting requested review from rroberts2222

Assignees

No one assigned

Labels

None yet

Projects

Foundational Infrastructure Working Group
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ctlong @Benjamintf1 @bosh-admin-bot