Migrate stop of rsyslogd to post-stop #133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the stopping of rsyslogd to post-stop phase, so that logs during stopping of bosh jobs are still forwarded to the configured syslog target. This addresses #131. Signed-off-by: Karsten Schnitter <[email protected]>
|
|
Member
|
@KarstenSchnitter looks like you're going to have to sign the CLA to proceed. Can you please do so :) |
KarstenSchnitter
changed the title
Contributor
Author
|
@ctlong signing the CLA has been done. |
mkocher
approved these changes
May 10, 2023
Member
mkocher
left a comment
mkocher
left a comment
There was a problem hiding this comment.
seems like a good change to me! Thanks @KarstenSchnitter
Member
|
Thank you all! Do you have an ETA on a new release with this fix? |
Member
|
We just cut a patch release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moves the stopping of rsyslogd to post-stop phase, so that logs during stopping of bosh jobs are still forwarded to the configured syslog target.
This addresses #131.
Type of change
Testing performed?
Checklist:
mainbranch, or relevant version branch