Headroom percentage vs. Headroom amount #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dmikusa
approved these changes
Mar 6, 2023
Contributor
|
Looks fine to me. Thanks for the PR. We will need to appease the EasyCLA bot before being able to merge. Sorry, it's a pain but a requirement. Thanks PS. Also, please bump this thread when EasyCLA is satisfied as it doesn't notify us. |
Contributor
Author
|
Thanks.
Will do. |
Contributor
Author
|
@dmikusa ping 😁 |
dmikusa
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reading the documentation, I got confused with the fact that there were two
headrooms used implicitly:This PR tries to improve the text, plus some language/format editing, by introducing a clear separation between those two things.