scriptAndVersionSettings.edit Missing settings part in multipart upload

[KayleeWilliams]

Confirm this is a Typescript library issue and not an underlying Cloudflare API issue

• This is an issue with the Typescript library

Describe the bug

I get the following error when I try to use workers.scripts.scriptAndVersionSettings.edit

" Error: 400 {"result":null,"success":false,"errors":[{"code":10201,"message":"Missing settings part in multipart upload. Ensure you include a settings part in the upload."}],"messages":[]}"

I do not get this message when I use the HTTP API. I get an ok esponse as expected

To Reproduce

1. Do following code snippet

Code snippets

await cloudflareClient.workers.scripts.scriptAndVersionSettings.edit(scriptName, {
		account_id: env.CLOUDFLARE_ACCOUNT_ID,
		settings: {
			bindings: [
				{
					name: 'XXX',
					text: 'XXX',
					type: 'secret_text',
				},
			],
		},
	});

OS

macOs

Runtime version

Typescript 5.8.3

Library version

4.3.0

[KaydeeDee]

Thank you for submitting an issue! I've sent it to the appropriate team to investigate.

[treet]

Same issue, appears to not be possible to add bindings to a worker through this library right now.

[karalabe]

I've hit the same problem from the Go library just now.

[karalabe]

The Go API generator is wrong, the generated code does not conform to the API spec cloudflare/cloudflare-go#4174 (comment). I'm assuming the same thing will happen typescript side too.

[treet]

Yes, appears to be the same problem! I just confirmed that this works:

import Cloudflare from 'cloudflare';

const client = new Cloudflare({ apiToken: API_TOKEN });

await client.workers.scripts.scriptAndVersionSettings.edit(
    SCRIPT_NAME,
    {
      account_id: ACCOUNT_ID,
      settings: {
        // ...
      },
    },
    { __multipartSyntax: 'json' }
  );

I suppose __multipartSyntax is nested by default, but the scriptAndVersionSettings endpoint only want the top level settings as a form parameter, the content of settings should be json.