Skip to content

Add namespace parameter to ml workbench module #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Add namespace parameter to ml workbench module #186

wants to merge 2 commits into from

Conversation

@jimright
Copy link
Contributor

@jimright jimright commented Sep 7, 2025

Also removes the tls alias for verify_tls in cdp_common.py.

Note that this change requires the namespace parameter to be exposed in the create ai workbench api.

@jimright jimright requested a review from a team September 7, 2025 06:59
@jimright jimright added the breaking MAJOR - Breaking entry in the CHANGELOG label Sep 7, 2025
@wmudge wmudge added bug POINT - Bugfix entry in the CHANGELOG and removed breaking MAJOR - Breaking entry in the CHANGELOG labels Sep 8, 2025
wmudge
wmudge requested changes Sep 8, 2025
View reviewed changes
Copy link
Member

@wmudge wmudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best if we can split this PR into two: one for the TLS parameter and the other for the namespace parameter.

@jimright
Copy link
Contributor Author

jimright commented Sep 8, 2025

Best if we can split this PR into two: one for the TLS parameter and the other for the namespace parameter.

Have opened #187 and #188 instead.

@jimright jimright closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wmudge wmudge wmudge requested changes

Assignees

No one assigned

Labels

bug POINT - Bugfix entry in the CHANGELOG

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jimright @wmudge